linux-kernel - Re: [PATCH 01/12] staging: usbip: userspace: migrate usbip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140305101541.GZ26722@mwanda>
Date:	Wed, 5 Mar 2014 13:15:41 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Valentina Manea <valentina.manea.m@...il.com>
Cc:	devel@...verdev.osuosl.org, shuah.kh@...sung.com,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	ly80toro@....cs.fau.de, tobias.polzer@....de,
	linux-kernel@...r.kernel.org, firefly@...ts.rosedu.org,
	dominik.paulus@....de, ihadzic@...earch.bell-labs.com
Subject: Re: [PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to
 libudev

On Wed, Mar 05, 2014 at 12:42:59PM +0300, Dan Carpenter wrote:
> On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote:
> > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.h b/drivers/staging/usbip/userspace/libsrc/usbip_common.h
> > index 2cb81b3..565ac78 100644
> > --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.h
> > +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.h
> > @@ -29,6 +29,15 @@
> >  #define USBIP_HOST_DRV_NAME	"usbip-host"
> >  #define USBIP_VHCI_DRV_NAME	"vhci_hcd"
> >  
> > +/* sysfs constants */
> > +#define SYSFS_MNT_PATH         "/sys"
> > +#define SYSFS_BUS_NAME         "bus"
> > +#define SYSFS_BUS_TYPE         "usb"
> > +#define SYSFS_DRIVERS_NAME     "drivers"
> 
> What on earth???  I don't even want to review any further than this.
> 
> Groan....  No.  no no no no no.
> 

I overreacted.  This stuff was already in the original code, and this
change just moves it around.

Fine fine.  These patch set seem ok with me.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/