lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Mar 2014 08:17:23 +0200 From: Valentina Manea <valentina.manea.m@...il.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: devel@...verdev.osuosl.org, shuah.kh@...sung.com, Greg KH <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org, ly80toro@....cs.fau.de, tobias.polzer@....de, linux-kernel@...r.kernel.org, "Linux Kernel Community @ ROSEdu" <firefly@...ts.rosedu.org>, dominik.paulus@....de, ihadzic@...earch.bell-labs.com Subject: Re: [PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to libudev On Wed, Mar 5, 2014 at 12:15 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote: > On Wed, Mar 05, 2014 at 12:42:59PM +0300, Dan Carpenter wrote: >> On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote: >> > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.h b/drivers/staging/usbip/userspace/libsrc/usbip_common.h >> > index 2cb81b3..565ac78 100644 >> > --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.h >> > +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.h >> > @@ -29,6 +29,15 @@ >> > #define USBIP_HOST_DRV_NAME "usbip-host" >> > #define USBIP_VHCI_DRV_NAME "vhci_hcd" >> > >> > +/* sysfs constants */ >> > +#define SYSFS_MNT_PATH "/sys" >> > +#define SYSFS_BUS_NAME "bus" >> > +#define SYSFS_BUS_TYPE "usb" >> > +#define SYSFS_DRIVERS_NAME "drivers" >> >> What on earth??? I don't even want to review any further than this. >> >> Groan.... No. no no no no no. >> > > I overreacted. This stuff was already in the original code, and this > change just moves it around. > > Fine fine. These patch set seem ok with me. > > regards, > dan carpenter > > Indeed, there are improvements than can be made to the code but I figured doing them all in just one patch series would be a step too big. This should be work for future patches. Thanks for your feedback. Valentina -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists