lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 06 Mar 2014 13:13:55 +0000 From: David Howells <dhowells@...hat.com> To: unlisted-recipients:; (no To-header on input) Cc: dhowells@...hat.com, Wolfram Sang <wsa@...-dreams.de>, wolfram@...-dreams.de, khali@...ux-fr.org, linux-i2c@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS David Howells <dhowells@...hat.com> wrote: > > Can we have something like this for 'flags'? > > There's a __print_flags() which should work. One thing I'm concerned about > there is how do we handle more flags being added - does that count as an ABI > break if the printed format changes? > > SMBus flags are basically the same as I2C flags, right? Hmmm... __print_flags() seems to append a string if a flag is set, and doesn't if it isn't set. It places a separator between each string. I would prefer something that emits a single char per flag or a dash if it isn't present. Are you okay with that? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists