linux-kernel - Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140306131729.GB10657@katana>
Date:	Thu, 6 Mar 2014 14:17:29 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	David Howells <dhowells@...hat.com>
Cc:	wolfram@...-dreams.de, khali@...ux-fr.org,
	linux-i2c@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS

On Thu, Mar 06, 2014 at 01:13:55PM +0000, David Howells wrote:
> David Howells <dhowells@...hat.com> wrote:
> 
> > > Can we have something like this for 'flags'?
> > 
> > There's a __print_flags() which should work.  One thing I'm concerned about
> > there is how do we handle more flags being added - does that count as an ABI
> > break if the printed format changes?
> > 
> > SMBus flags are basically the same as I2C flags, right?
> 
> Hmmm... __print_flags() seems to append a string if a flag is set, and doesn't
> if it isn't set.  It places a separator between each string.  I would prefer
> something that emits a single char per flag or a dash if it isn't present.
> Are you okay with that?

Yes, that's good, too!

Thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)