lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Mar 2014 11:53:56 -0800 From: Greg KH <gregkh@...uxfoundation.org> To: "Maxin B. John" <maxin.john@...il.com> Cc: linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org, andreas.dilger@...el.com, bergwolf@...il.com, alexey.zhuravlev@...el.com, josh@...htriplett.org, dulshani.gunawardhana89@...il.com, jinshan.xiong@...el.com, "Maxin B. John" <maxin.john@...a.com> Subject: Re: [PATCH 2/2] lustre/lov_obd: fix possible null pointer dereference On Wed, Mar 05, 2014 at 02:04:36PM +0100, Maxin B. John wrote: > From: "Maxin B. John" <maxin.john@...a.com> > > osc_obd can be NULL. cppcheck reported this: > [lustre/lustre/lov/lov_obd.c:283]: (error) Possible null pointer dereference: > osc_obd - otherwise it is redundant to check if osc_obd is null at line 295 Same problem, osc_obd can never be NULL, please be more careful with your patches, and just remove pointless tests instead of papering over them with patches like this. thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists