linux-kernel - Re: [PATCH 1/2] lustre/mdc_lib: fix possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMhs6YzPcTnLO2rwny0binzLFT+TNJUwVhintGHYitgJ4=kiaQ@mail.gmail.com>
Date:	Thu, 6 Mar 2014 22:41:54 +0100
From:	"Maxin B. John" <maxin.john@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	devel@...verdev.osuosl.org, andreas.dilger@...el.com,
	Peng Tao <bergwolf@...il.com>, alexey.zhuravlev@...el.com,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Dulshani Gunawardhana <dulshani.gunawardhana89@...il.com>,
	josh@...htriplett.org, jinshan.xiong@...el.com,
	"Maxin B. John" <maxin.john@...a.com>
Subject: Re: [PATCH 1/2] lustre/mdc_lib: fix possible null pointer dereference

Hi,

On Thu, Mar 6, 2014 at 8:51 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Wed, Mar 05, 2014 at 09:53:06PM +0300, Dan Carpenter wrote:
>> On Wed, Mar 05, 2014 at 02:04:35PM +0100, Maxin B. John wrote:
>> > From: "Maxin B. John" <maxin.john@...a.com>
>> >
>> > cppcheck reported possible null pointer dereference in mdc_lib.c
>> >
>> > [lustre/lustre/mdc/mdc_lib.c:233]: (error) Possible null pointer dereference
>> > : op_data - otherwise it is redundant to check if op_data is null at line 226
>> >
>>
>> There is only one caller and "op_data" is not NULL.
>
> I agree, John, please fix your tools.  Or check the result and fix the
> code so that there isn't false-positives (by not checking for NULL at
> all here...)

Thanks to Dan and Greg for the comments. Will try my best to avoid
these kind of mistakes in future.

> thanks,
> greg k-h

Best Regards,
Maxin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/