linux-kernel - [PATCH] proc: #68991 Fix GPF in /proc/$PID/map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140308022033.GC5690@owamsq.epam.com>
Date:	Sat, 8 Mar 2014 05:20:33 +0300
From:	Artem Fetishev <artem_fetishev@...m.com>
To:	<akpm@...ux-foundation.org>
CC:	<containers@...ts.linux-foundation.org>,
	<linux-kernel@...r.kernel.org>, <wiebittewas@...glemail.com>,
	<xemul@...allels.com>, <alexandr_terekhov@...m.com>
Subject: [PATCH] proc: #68991 Fix GPF in /proc/$PID/map_files

https://bugzilla.kernel.org/show_bug.cgi?id=68991

The expected logic of proc_map_files_get_link() is either to return 0 and
initialize 'path' or return an error and leave 'path' uninitialized. By the time
dname_to_vma_addr() returns 0 the corresponding vma may have already be gone. In
this case the path is not initialized but the return value is still 0. This
results in 'general protection fault' inside d_path().

Steps to reproduce:
CONFIG_CHECKPOINT_RESTORE=y

fd = open(...);
while (1) {
	mmap(fd, ...);
	munmap(fd, ...);
}

ls -la /proc/$PID/map_files

Signed-off-by: Artem Fetishev <artem_fetishev@...m.com>
Signed-off-by: Aleksandr Terekhov <aleksandr_terekhov@...m.com>
---
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 5150706..b976062 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1824,6 +1824,7 @@ static int proc_map_files_get_link(struct dentry *dentry, struct path *path)
 	if (rc)
 		goto out_mmput;
 
+	rc = -ENOENT;
 	down_read(&mm->mmap_sem);
 	vma = find_exact_vma(mm, vm_start, vm_end);
 	if (vma && vma->vm_file) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/