[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140310144429.GA13661@lee--X1>
Date: Mon, 10 Mar 2014 14:44:29 +0000
From: Lee Jones <lee.jones@...aro.org>
To: Maxime COQUELIN <maxime.coquelin@...com>
Cc: Rob Landley <rob@...dley.net>, Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Russell King <linux@....linux.org.uk>,
Srinivas Kandagatla <srinivas.kandagatla@...com>,
Stuart Menefy <stuart.menefy@...com>,
Linus Walleij <linus.walleij@...aro.org>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
kernel@...inux.com
Subject: Re: [PATCH v3 3/5] pinctrl: st: add pinctrl support for the STiH407
SoC
> From: Giuseppe Cavallaro <peppe.cavallaro@...com>
>
> This patch adds the initial support for pinctrl based on H407 SoC.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@...com>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
SOBs should be in order of submission flow and author's should only be
kept if the patch is unchanged. If it's been adapted you will require
a re-review and they Acked-by or Reviewed-by tag.
> ---
> drivers/pinctrl/pinctrl-st.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1721611..d1886b4 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -390,6 +390,19 @@ static const struct st_pctl_data stih416_data = {
> .alt = 0, .oe = 40, .pu = 50, .od = 60, .rt = 100,
> };
>
> +static const struct st_pctl_data stih407_flashdata = {
Nit: Double space.
> + .rt_style = st_retime_style_none,
> + .input_delays = stih416_delays,
> + .ninput_delays = 14,
ARRAY_SIZE(stih416_delays)
> + .output_delays = stih416_delays,
> + .noutput_delays = 14,
ARRAY_SIZE(stih416_delays)
> + .alt = 0,
> + .oe = -1, /* Not Available */
> + .pu = -1, /* Not Available */
> + .od = 60,
> + .rt = 100,
> +};
> +
> /* Low level functions.. */
> static inline int st_gpio_bank(int gpio)
> {
> @@ -1596,6 +1609,10 @@ static struct of_device_id st_pctl_of_match[] = {
> { .compatible = "st,stih416-rear-pinctrl", .data = &stih416_data},
> { .compatible = "st,stih416-fvdp-fe-pinctrl", .data = &stih416_data},
> { .compatible = "st,stih416-fvdp-lite-pinctrl", .data = &stih416_data},
> + { .compatible = "st,stih407-sbc-pinctrl", .data = &stih416_data},
> + { .compatible = "st,stih407-front-pinctrl", .data = &stih416_data},
> + { .compatible = "st,stih407-rear-pinctrl", .data = &stih416_data},
> + { .compatible = "st,stih407-flash-pinctrl", .data = &stih407_flashdata},
> { /* sentinel */ }
> };
After the small changes above, feel free to add my:
Acked-by: Lee Jones <lee.jones@...aro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists