linux-kernel - Re: [PATCH] RFC: WIP: sc16is7xx [v0.4]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394468076.709210210@f170.i.mail.ru>
Date:	Mon, 10 Mar 2014 20:14:36 +0400
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Jon Ringle <jon@...gle.org>
Cc:	gregkh@...uxfoundation.org, jslaby@...e.cz,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Jon Ringle <jringle@...dpoint.com>
Subject: Re: [PATCH] RFC: WIP: sc16is7xx [v0.4]

Понедельник, 10 марта 2014, 7:50 -04:00 от Jon Ringle <jon@...gle.org>:
> 
> On Mon, 10 Mar 2014, Alexander Shiyan wrote:
> 
> > Понедельник, 10 марта 2014, 2:26 -04:00 от jon@...gle.org:
> > > From: Jon Ringle <jringle@...dpoint.com>
> > ...
> > > +config SERIAL_SC16IS7XX
> > > +	tristate "SC16IS7xx RS485 serial support"
> > > +	  select SERIAL_CORE
> > > +	  default n
> > > +	  help
> > > +	  This selects support for SC16IS7xx for use as a RS485 serial port
> > 
> > Documentation says:
> > The SC16IS740/750/760 is a slave I²C-bus/SPI interface to a single-channel
> > high performance UART.
> > ...
> > The SC16IS740/750/760 also provides additional advanced features such
> > as auto hardware and software flow control, automatic RS-485 support...
> > 
> > So why do you position this chip as RS485 only? Automatic direction for
> > RS485 is just a feature as an addition for standart UART.
> 
> You're right. This is just how we are using the chip in our board. Would a 
> configuration flag in platform_data make sense to use the auto rs485 
> direction?

You don't need a flag, just use IOCTLs.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/tty/serial/max310x.c?id=55367c620aed6bc27a82bb1763366931d7f2ee66

> Any thoughts as to the latency issue I report?

I do not understand why you chose the sccnxp driver as a template.
Use as a template max310x driver from linux-next branch.
I'm sure it will be better.

About latency.
I'm not exactly understand the problem, but I can say the following:
Since you're using the I2C bus, maximum UART daudrate can be
predicted from the I2C bus bandwidth.
Count how many I2C clocks spent on reception and transmission
of one byte through UART.

---