linux-kernel - Re: [PATCH] module: LLVMLinux: Remove unused function warning from __param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531EB484.5070204@converseincode.com>
Date:	Tue, 11 Mar 2014 00:00:20 -0700
From:	Behan Webster <behanw@...verseincode.com>
To:	Rusty Russell <rusty@...tcorp.com.au>, khali@...ux-fr.org,
	rostedt@...dmis.org
CC:	linux-kernel@...r.kernel.org, dwmw2@...radead.org,
	pageexec@...email.hu, Mark Charlebois <charlebm@...il.com>
Subject: Re: [PATCH] module: LLVMLinux: Remove unused function warning from
 __param_check macro

On 03/10/14 23:11, Rusty Russell wrote:
> behanw@...verseincode.com writes:
>> From: Mark Charlebois <charlebm@...il.com>
>>
>> This code makes a compile time type check that is optimized away. Clang
>> complains that it generates an unused function.
>>
>> I believe GCC won't complain for a static inline fuction but would if it
>> was just a static function.
>>
>> Adding the unused attribute to the function declaration removes the warning.
>>
>> This code works for both gcc and clang.
>>
>> Signed-off-by: Mark Charlebois <charlebm@...il.com>
>> Signed-off-by: Behan Webster <behanw@...verseincode.com>
> Please include the actual warning clang spits out.  That helps because
> (1) I know what you're referring to, and
> (2) it helps others if they are later googling for the error.
Nice! Will fix.

> I don't have any huge objections to this patch (__always_unused) though.
Already in the posted v2 patch.

However I will post a v3 with your other suggested changes to the commit 
message.

Thanks,

Behan

-- 
Behan Webster
behanw@...verseincode.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/