| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140311083107.6aa2bba4@gandalf.local.home> Date: Tue, 11 Mar 2014 08:31:07 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Behan Webster <behanw@...verseincode.com> Cc: fweisbec@...il.com, mingo@...hat.com, linux@....linux.org.uk, kpark3469@...il.com, keun-o.park@...driver.com, dave.martin@...aro.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] arm: LLVMLinux: use static inline in ARM ftrace.h On Tue, 11 Mar 2014 00:01:44 -0700 Behan Webster <behanw@...verseincode.com> wrote: > On 02/20/14 18:22, behanw@...verseincode.com wrote: > > From: Behan Webster <behanw@...verseincode.com> > > > > With compilers which follow the C99 standard (like modern versions of gcc and > > clang), "extern inline" does the wrong thing (emits code for an externally > > linkable version of the inline function). In this case using static inline > > and removing the NULL version of return_address in return_address.c does > > the right thing. > Any input? Is it good as it is? I'm fine with it. But you need approval from the arm folks. I know there was some issues with the return_address() code in the past. But from the ftrace perspective: Acked-by: Steven Rostedt <rostedt@...dmis.org> -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists