linux-kernel - Re: [PATCH RT 2/5] a few open coded completions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140310225623.0cad071a@gandalf.local.home>
Date:	Mon, 10 Mar 2014 22:56:23 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linux-kernel@...r.kernel.org,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Carsten Emde <C.Emde@...dl.org>,
	John Kacur <jkacur@...hat.com>,
	Corey Minyard <cminyard@...sta.com>
Subject: Re: [PATCH RT 2/5] a few open coded completions

On Tue, 11 Mar 2014 02:06:46 +0000
Ben Hutchings <ben@...adent.org.uk> wrote:

> > I don't run a make allmodconfig as I do on my upstream work. Maybe I'll
> > have to add that to the mix.
> 
> You can enable all the affected code with:
> 
> CONFIG_HERMES=m
> CONFIG_ORINOCO_USB=m
> CONFIG_USB_GADGET=m
> CONFIG_USB_FUNCTIONFS=m
> CONFIG_USB_GADGETFS=m

Thanks, I ran an allmodconfig, and you're right, the orinoco driver
failed to compile on v3.2-rt. I ran allmodconfig on 3.10-rt and it
passed fine. Seems that one of the headers there pulls in swait.

Looking deeper, 3.10-rt has completion as a simple-wait, and
completion.h pulls in wait-simple.h, which is why it works there. 3.2
does not have completions there. I wonder if I should pull in the patch
that converts completions into swaits, and that may fix other locations
as well.

I'll give it a try.

Thanks,

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/