linux-kernel - Re: [PATCH RT 2/5] a few open coded completions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1394648128.23624.32.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 12 Mar 2014 18:15:28 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linux-kernel@...r.kernel.org,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Carsten Emde <C.Emde@...dl.org>,
	John Kacur <jkacur@...hat.com>,
	Corey Minyard <cminyard@...sta.com>
Subject: Re: [PATCH RT 2/5] a few open coded completions

On Tue, 2014-03-11 at 11:54 -0400, Steven Rostedt wrote:
> On Mon, 10 Mar 2014 22:56:23 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> 
> > Thanks, I ran an allmodconfig, and you're right, the orinoco driver
> > failed to compile on v3.2-rt. I ran allmodconfig on 3.10-rt and it
> > passed fine. Seems that one of the headers there pulls in swait.
> > 
> > Looking deeper, 3.10-rt has completion as a simple-wait, and
> > completion.h pulls in wait-simple.h, which is why it works there. 3.2
> > does not have completions there. I wonder if I should pull in the patch
> > that converts completions into swaits, and that may fix other locations
> > as well.
> 
> The swait code for 3.2 can't even handle the changes that were made.
> That is, the patch used swait functions not created in 3.2-rt.
> 
> I'll just revert those from 3.2-rt and be done with it.
> 
> Thanks for the report.

OK.  Sorry for the 'WTF'; now I understand that this was a build fix for
the later branches.

Ben.

-- 
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)