linux-kernel - Re: [PATCH V2] Change ACPI IPMI support to "default y"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140313083832.GA8902@amd.pavel.ucw.cz>
Date:	Thu, 13 Mar 2014 09:38:32 +0100
From:	Pavel Machek <pavel@....cz>
To:	Matthew Garrett <matthew.garrett@...ula.com>
Cc:	"lenb@...nel.org" <lenb@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"minyard@....org" <minyard@....org>,
	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH V2] Change ACPI IPMI support to "default y"

On Thu 2014-03-13 07:24:36, Matthew Garrett wrote:
> On Thu, 2014-03-13 at 08:22 +0100, Pavel Machek wrote:
> > On Wed 2014-03-12 23:22:49, Matthew Garrett wrote:
> > > No. The power meter driver knows nothing about IPMI. It makes no IPMI
> > > calls. There's no requirement that a vendor implement it via IPMI.
> > 
> > Yet you claim that IMPI is needed for that, and that's why you made
> > IMPI default.
> 
> I claim that the ACPI spec defines the behaviour of IPMI operation
> regions, and so we should default IPMI to Y in order to (by default)
> implement the ACPI spec.
> 
> > So ... do we need dmi-based blacklist?
> 
> I don't see why.

Your reasoning for default y was that "power meter depends on
this". Then, claim that "power meter does not officially depend on it"
so it would be wrong to have a dependency.

Defaults are not right solution; system should still work if I select
non-default settings. Which you claim is not a case, but you don't see
why you should fix it.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/