linux-kernel - Re: [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140313140901.GW366@sirena.org.uk>
Date:	Thu, 13 Mar 2014 14:09:01 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	Robert Baldyga <r.baldyga@...sung.com>, sameo@...ux.intel.com,
	myungjoo.ham@...sung.com, dmitry.torokhov@...il.com,
	cooloney@...il.com, rpurdie@...ys.net, dbaryshkov@...il.com,
	dwmw2@...radead.org, lgirdwood@...il.com, a.zummo@...ertech.it,
	paul.gortmaker@...driver.com, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, linux-leds@...r.kernel.org,
	rtc-linux@...glegroups.com, m.szyprowski@...sung.com,
	k.kozlowski@...sung.com
Subject: Re: [PATCH v3 4/4] mfd: max8997: move regmap handling to function
 drivers

On Thu, Mar 13, 2014 at 12:55:04PM +0000, Lee Jones wrote:
> > Is it necessary? If previous mfd driver has various i2c line, previous mfd driver
> > initialize regmap/i2c setting on mfd driver.
> > I'm not sure that regmap/i2c setting code move from mfd driver to each driver.
> > 
> > Dear Lee Jones,
> > I need your opinion about moving regmap/i2c code from mfd driver to each driver.

> I'd rather take advice from Mark on this one.

I don't really case that much; I'm having a hard time seeing it as
particularly useful to do the refactoring but if it makes people
happy...  Keeping things in the core would help promote reusability I
guess but I'm not sure that's likely to actually happen with this sort
of driver/device.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)