linux-kernel - async_pf.c && use_mm() (Was: mm,vmacache: also flush cache for VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140313182702.GA3429@redhat.com>
Date:	Thu, 13 Mar 2014 19:27:02 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Gleb Natapov <gleb@...hat.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Davidlohr Bueso <davi@...hat.com>,
	Davidlohr Bueso <davidlohr@...com>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mgorman@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michel Lespinasse <walken@...gle.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: async_pf.c && use_mm() (Was: mm,vmacache: also flush cache for
	VM_CLONE)

On 03/13, Oleg Nesterov wrote:
>
> Hmm, but at first glance async_pf_execute() doesn't need use_mm() at all.

Seriously, why it nees use_mm? get_user_pages(mm => apf->mm) should work.
Perhaps there is some kvm magic ?

But actually I am writing this email because mmdrop() doesn't look right
or I missed something. I think that kvm_setup_async_pf() should increment
->mm_users and async_pf_execute() needs mmput() ?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/