linux-kernel - Re: [PATCH v11 01/27] iommu/exynos: do not include removed header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK9yfHyGfdP+0RKtdSCdU4tO=PX8GbQRQ7ar=ST5B2RenZMMsg@mail.gmail.com>
Date:	Fri, 14 Mar 2014 17:29:36 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Cho KyongHo <pullip.cho@...sung.com>
Cc:	Linux ARM Kernel <linux-arm-kernel@...ts.infradead.org>,
	Linux DeviceTree <devicetree@...r.kernel.org>,
	Linux IOMMU <iommu@...ts.linux-foundation.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Linux Samsung SOC <linux-samsung-soc@...r.kernel.org>,
	Antonios Motakis <a.motakis@...tualopensystems.com>,
	Grant Grundler <grundler@...omium.org>,
	Joerg Roedel <joro@...tes.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Prathyush <prathyush.k@...sung.com>,
	Rahul Sharma <rahul.sharma@...sung.com>,
	Varun Sethi <Varun.Sethi@...escale.com>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Tomasz Figa <t.figa@...sung.com>
Subject: Re: [PATCH v11 01/27] iommu/exynos: do not include removed header

On 14 March 2014 17:19, Cho KyongHo <pullip.cho@...sung.com> wrote:
>> From: Sachin Kamat [mailto:sachin.kamat@...aro.org]
>> Sent: Friday, March 14, 2014 7:00 PM
>>
>> On 14 March 2014 10:31, Cho KyongHo <pullip.cho@...sung.com> wrote:
>> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
>> > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
>> > removing remaining use of it from exynos-iommu driver, thus causing a
>> > compilation error.
>> >
>> > This patch fixes the error by removing respective include line
>> > from exynos-iommu.c.
>> >
>> > CC: Tomasz Figa <t.figa@...sung.com>
>> > Signed-off-by: Cho KyongHo <pullip.cho@...sung.com>
>> > ---
>> >  drivers/iommu/exynos-iommu.c |    3 +--
>> >  1 file changed, 1 insertion(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
>> > index 0740189..4876d35 100644
>> > --- a/drivers/iommu/exynos-iommu.c
>> > +++ b/drivers/iommu/exynos-iommu.c
>> > @@ -12,6 +12,7 @@
>> >  #define DEBUG
>> >  #endif
>> >
>> > +#include <linux/kernel.h>
>>
>> This change doesn't look related to the patch subject/description.
>>
> Yes. But it is simply added without any side-effect.
> Do you think it should be in a separate patch?.
> Actually, the added line is a redundant.

If it is redundant, then you shouldn't be adding it. If it is
required, then please
mention about the need in the commit description if not a separate patch.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/