linux-kernel - RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71f42b215c58414d8bfa7efb968dadbf@BN1PR03MB251.namprd03.prod.outlook.com>
Date:	Fri, 14 Mar 2014 20:52:19 +0000
From:	"suresh.gupta@...escale.com" <suresh.gupta@...escale.com>
To:	"balbi@...com" <balbi@...com>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform
 device id

Hi,
Thanks for reviewing my patches.
Please find my comments inline

-----Original Message-----
From: Felipe Balbi [mailto:balbi@...com] 
Sent: Thursday, March 13, 2014 8:56 PM
To: Gupta Suresh-B42813
Cc: balbi@...com; gregkh@...uxfoundation.org; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Gupta Suresh-B42813
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id

On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
> From: Suresh Gupta <B42813@...escale.com>
> 
> 	Add FSL USB Gadget entry in platform device id table

why this tab ?
[SuresH] I will remove it in next version. 

> Signed-off-by: Suresh Gupta <B42813@...escale.com>
> ---
>  drivers/usb/gadget/fsl_udc_core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
> index b7dea4e..35b20e6 100644
> --- a/drivers/usb/gadget/fsl_udc_core.c
> +++ b/drivers/usb/gadget/fsl_udc_core.c
> @@ -2654,6 +2654,8 @@ static const struct platform_device_id fsl_udc_devtype[] = {
>  	}, {
>  		.name = "imx-udc-mx51",
>  	}, {
> +		.name = "fsl-usb2-udc",

why aren't you just using chipidea ?
[SuresH] This is our legacy driver for all previous and existing ppc socs. Many of our customers are already using this, and we need to support them on this driver. We do have plans to shift to chipidea, but after some time. 

-- 
Thanks
SuresH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/