linux-kernel - Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Mar 2014 20:40:15 -0500
From:	Felipe Balbi <balbi@...com>
To:	"suresh.gupta@...escale.com" <suresh.gupta@...escale.com>
CC:	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform
 device id

On Fri, Mar 14, 2014 at 08:52:19PM +0000, suresh.gupta@...escale.com wrote:
> Hi,
> Thanks for reviewing my patches.
> Please find my comments inline
> 
> -----Original Message-----
> From: Felipe Balbi [mailto:balbi@...com] 
> Sent: Thursday, March 13, 2014 8:56 PM
> To: Gupta Suresh-B42813
> Cc: balbi@...com; gregkh@...uxfoundation.org; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Gupta Suresh-B42813
> Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id
> 
> On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
> > From: Suresh Gupta <B42813@...escale.com>
> > 
> > 	Add FSL USB Gadget entry in platform device id table
> 
> why this tab ?
> [SuresH] I will remove it in next version. 
> 
> > Signed-off-by: Suresh Gupta <B42813@...escale.com>
> > ---
> >  drivers/usb/gadget/fsl_udc_core.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
> > index b7dea4e..35b20e6 100644
> > --- a/drivers/usb/gadget/fsl_udc_core.c
> > +++ b/drivers/usb/gadget/fsl_udc_core.c
> > @@ -2654,6 +2654,8 @@ static const struct platform_device_id fsl_udc_devtype[] = {
> >  	}, {
> >  		.name = "imx-udc-mx51",
> >  	}, {
> > +		.name = "fsl-usb2-udc",
> 
> why aren't you just using chipidea ?
> [SuresH] This is our legacy driver for all previous and existing ppc
> socs. Many of our customers are already using this, and we need to
> support them on this driver. We do have plans to shift to chipidea,
> but after some time. 

cool, you already have plans, so we will see a new glue layer for v3.16
right ? Which means I don't need to take this patch either.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)