linux-kernel - Re: [PATCH 0/2] KVM: x86 emulator: emulate MOVAPS and MOVAPD SSE instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5326DA5D.7040503@redhat.com>
Date:	Mon, 17 Mar 2014 12:19:57 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	"H. Peter Anvin" <hpa@...or.com>,
	Igor Mammedov <imammedo@...hat.com>,
	linux-kernel@...r.kernel.org
CC:	gleb@...nel.org, tglx@...utronix.de, mingo@...hat.com,
	x86@...nel.org, kvm@...r.kernel.org
Subject: Re: [PATCH 0/2] KVM: x86 emulator: emulate MOVAPS and MOVAPD SSE
 instructions

Il 15/03/2014 23:39, H. Peter Anvin ha scritto:
> MOVAPS, MOVAPD, and MOVDQA are the same operation.  They may, architecturally, have different performance characteristics, but nothing that would affect an emulator.

In fact MOVAPS and MOVAPD are implemented the same way in this patch:

I(Aligned, em_mov), I(Aligned, em_mov), N, N,

These are respectively for no prefix, 0x66, 0xf2 and 0xf3.  MOVDQA was 
already implemented, but on AMD some memcpy implementations use MOVAPS 
because it's a byte shorter.

Paolo

> On March 15, 2014 1:01:58 PM PDT, Igor Mammedov <imammedo@...hat.com> wrote:
>> MS HCK test fails on 32-bit Windows 8.1 due to missing MOVAPS
>> instruction emulation, this series adds it and while at it,
>> it adds emulation of MOVAPD which is trivial to implement on
>> top of MOVAPS.
>>
>> Igor Mammedov (2):
>>  KVM: x86 emulator: emulate MOVAPS
>>  KVM: x86 emulator: emulate MOVAPD
>>
>> arch/x86/kvm/emulate.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/