linux-kernel - Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140317152847.GI11706@sirena.org.uk>
Date:	Mon, 17 Mar 2014 15:28:47 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Boris BREZILLON <b.brezillon.dev@...il.com>
Cc:	Bo Shen <voice.shen@...el.com>, nicolas.ferre@...el.com,
	Boris BREZILLON <b.brezillon@...rkiz.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Subject: Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904
 driver

On Mon, Mar 17, 2014 at 02:44:00PM +0100, Boris BREZILLON wrote:
> Le 17/03/2014 12:55, Mark Brown a écrit :
> >On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote:

> >If this is a clock for the CODEC it should be documented as part of the
> >binding for the CODEC and connected to the CODEC in the device tree
> >rather than being part of a machine driver binding.

> Tell me if I'm mistaken, but doing this would implies a lot of changes.
> The current wm8904 driver does not handle clk retrieval and configuration,
> and I'm afraid that introducing these concepts would break other drivers
> (those
> connecting to a wm8904 codec).

Currently the only mainline users of the device are the Atmel drivers.

> How about adding CCF support as proposed in this series and think about a
> cleaner
> solution for a future release ?

No, DT is an ABI so you can't do that - once something is in DT we're
stuck supporting it so we can't do quick hacks so easily.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)