linux-kernel - Re: [PATCH] ARM: kdump: Avoid overflow when converting pfn to physaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140318104855.GU21483@n2100.arm.linux.org.uk>
Date:	Tue, 18 Mar 2014 10:48:55 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Liu Hua <sdu.liu@...wei.com>
Cc:	wangnan0@...wei.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, peifeiyue@...wei.com
Subject: Re: [PATCH] ARM: kdump: Avoid overflow when converting pfn to
	physaddr

On Tue, Mar 18, 2014 at 06:20:42PM +0800, Liu Hua wrote:
> When we configure CONFIG_LPAE=y, pfn << PAGE_SHIFT will
> overflow if pfn >= 0x100000 in copy_oldmem_page.
> 
> So use __pfn_to_phys for converting.

Yes.  The sad thing is that if you grep the kernel for similar things,
it's littered with this problem.  I'm not sure whether anyone
particularly "owns" the crash_dump.c file - Mika Westerberg and
Olaf Hering were the last two to touch it... I guess put this in my
patch system please.

Thanks.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/