lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Mar 2014 19:52:10 +0900 From: Cho KyongHo <pullip.cho@...sung.com> To: Tomasz Figa <t.figa@...sung.com> Cc: Linux ARM Kernel <linux-arm-kernel@...ts.infradead.org>, Linux DeviceTree <devicetree@...r.kernel.org>, Linux IOMMU <iommu@...ts.linux-foundation.org>, Linux Kernel <linux-kernel@...r.kernel.org>, Linux Samsung SOC <linux-samsung-soc@...r.kernel.org>, Antonios Motakis <a.motakis@...tualopensystems.com>, Grant Grundler <grundler@...omium.org>, Joerg Roedel <joro@...tes.org>, Kukjin Kim <kgene.kim@...sung.com>, Prathyush <prathyush.k@...sung.com>, Rahul Sharma <rahul.sharma@...sung.com>, Sachin Kamat <sachin.kamat@...aro.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>, Varun Sethi <Varun.Sethi@...escale.com> Subject: Re: [PATCH v11 13/27] iommu/exynos: support for device tree On Fri, 14 Mar 2014 14:39:33 +0100, Tomasz Figa wrote: > Hi KyongHo, > > On 14.03.2014 06:09, Cho KyongHo wrote: > > This commit adds device tree support for System MMU. > > > > Signed-off-by: Cho KyongHo <pullip.cho@...sung.com> > > --- > > drivers/iommu/Kconfig | 5 ++--- > > drivers/iommu/exynos-iommu.c | 21 +++++++++++++++++---- > > 2 files changed, 19 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > > index df56e4c..22af807 100644 > > --- a/drivers/iommu/Kconfig > > +++ b/drivers/iommu/Kconfig > > @@ -178,16 +178,15 @@ config TEGRA_IOMMU_SMMU > > > > config EXYNOS_IOMMU > > bool "Exynos IOMMU Support" > > - depends on ARCH_EXYNOS && EXYNOS_DEV_SYSMMU > > + depends on ARCH_EXYNOS > > select IOMMU_API > > + default n > > help > > Support for the IOMMU(System MMU) of Samsung Exynos application > > nit: There should be a white space before the opening parenthesis. > Ok. :) > > processor family. This enables H/W multimedia accellerators to see > > typo: s/accellerators/accelerators/ > Ok. > > non-linear physical memory chunks as a linear memory in their > > address spaces > > > > - If unsure, say N here. > > - > > config EXYNOS_IOMMU_DEBUG > > bool "Debugging log for Exynos IOMMU" > > depends on EXYNOS_IOMMU > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > > index 33b424d..34feb04 100644 > > --- a/drivers/iommu/exynos-iommu.c > > +++ b/drivers/iommu/exynos-iommu.c > > @@ -26,6 +26,7 @@ > > #include <linux/list.h> > > #include <linux/memblock.h> > > #include <linux/export.h> > > +#include <linux/of.h> > > > > #include <asm/cacheflush.h> > > #include <asm/pgtable.h> > > @@ -497,7 +498,7 @@ void exynos_sysmmu_tlb_invalidate(struct device *dev) > > read_unlock_irqrestore(&data->lock, flags); > > } > > > > -static int exynos_sysmmu_probe(struct platform_device *pdev) > > +static int __init exynos_sysmmu_probe(struct platform_device *pdev) > > { > > int irq, ret; > > struct device *dev = &pdev->dev; > > @@ -557,11 +558,23 @@ static int exynos_sysmmu_probe(struct platform_device *pdev) > > return 0; > > } > > > > -static struct platform_driver exynos_sysmmu_driver = { > > - .probe = exynos_sysmmu_probe, > > - .driver = { > > +#ifdef CONFIG_OF > > +static struct of_device_id sysmmu_of_match[] __initconst = { > > + { .compatible = "samsung,sysmmu-v1", }, > > + { .compatible = "samsung,sysmmu-v2", }, > > + { .compatible = "samsung,sysmmu-v3.1", }, > > + { .compatible = "samsung,sysmmu-v3.2", }, > > + { .compatible = "samsung,sysmmu-v3.3", }, > > Do you need all these compatible strings? I mean, are there any > implementation differences that can't be identified by reading IP > registers, such as REG_MMU_VERSION? > Unfortunately, there is a SoC which overrides REG_MMU_VERSION with a value for RTL designers and it is not related to System MMU versions. Thank you. KyongHo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists