linux-kernel - Re: [PATCH] SPI: Add driver for Cadence SPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140318123348.GR11706@sirena.org.uk>
Date:	Tue, 18 Mar 2014 12:33:48 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Harini Katakam <harini.katakam@...inx.com>
Cc:	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"rob@...dley.net" <rob@...dley.net>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	Michal Simek <michals@...inx.com>
Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller

On Tue, Mar 18, 2014 at 12:13:45PM +0000, Harini Katakam wrote:

> I'm going to remove the bits_per_word check anyway.
> But the clock configuration still needs to be done.
> Where should it be done spi_setup() or transfer?

It needs to be done on the transfer - that is required anyway since the
clock rate is specified per transfer.

> > > In this case both possible interrupt conditions are handled.

> > Are you sure that's the case, and even if you are that's still not
> > handling the case where the device isn't flagging an interrupt at all.

> The IXR_ALL mask is only used to disable all the interrupts in the beginning.
> These two are the only interrupts enabled.
> And RXNEMPTY status is just polled. That interrupt is not enabled either

This is all going to be fragile in the face of bugs or changes in the
code though and like I keep saying it doesn't handle interrupt sharing.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)