linux-kernel - Re: [PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140319090920.GE1665@opensource.wolfsonmicro.com>
Date:	Wed, 19 Mar 2014 09:09:20 +0000
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	rob@...dley.net, sameo@...ux.intel.com, lee.jones@...aro.org,
	lgirdwood@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] regulator: arizona-ldo1: Move setup processing
	from arizona-core

On Tue, Mar 18, 2014 at 05:44:30PM +0000, Mark Brown wrote:
> On Tue, Mar 18, 2014 at 05:22:31PM +0000, Charles Keepax wrote:
> 
> > -	/*
> > -	 * LDO1 can only be used to supply DCVDD so if it has no
> > -	 * consumers then DCVDD is supplied externally.
> > -	 */
> > -	if (arizona->pdata.ldo1 &&
> > -	    arizona->pdata.ldo1->num_consumer_supplies == 0)
> > -		arizona->external_dcvdd = true;
> > -
> 
> Actually now that I look at this again one issue here - the reason this
> is in the core is that if the system is using an external DCVDD it may
> not be building the regulator driver at all (it won't do anything at
> runtime) so the flag would never get set if it's done by the regulator
> driver.

Ah... missed that. I will respin again.

Thanks,
Charles

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/