linux-kernel - Re: [percpu] BUG: using __this_cpu_add() in preemptible [00000000] code: init/1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140319153851.34dfdf97616422b159dc153b@linux-foundation.org>
Date:	Wed, 19 Mar 2014 15:38:51 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Christoph Lameter <cl@...ux.com>
Cc:	Fengguang Wu <fengguang.wu@...el.com>,
	linux-kernel@...r.kernel.org, Pekka Enberg <penberg@...nel.org>
Subject: Re: [percpu]  BUG: using __this_cpu_add() in preemptible [00000000]
 code: init/1

On Tue, 18 Mar 2014 09:43:27 -0500 (CDT) Christoph Lameter <cl@...ux.com> wrote:

> Anyways the statistics in slub should be low impact and able to
> be placed anywhere. So I think we need this patch to avoid
> the preemption checks begin triggered.
> 
> 
> Subject: SLUB: Use raw_cpu_inc for incrementing statistics
> 
> Statistics are not critical to the operation of the allocation
> but should also not cause too much overhead.
> 
> __this_cpu_inc now checks if preemption is disabled and triggers.
> Use raw_cpu_inc to avoid the checks. Using this_cpu_ops may cause
> interrupt disable/enable sequences on various arches which may
> significantly impact allocator performance.
> 
> ...
>
> --- linux.orig/mm/slub.c	2014-03-07 14:10:30.142777022 -0600
> +++ linux/mm/slub.c	2014-03-18 09:39:15.675035324 -0500
> @@ -224,7 +224,7 @@
>  static inline void stat(const struct kmem_cache *s, enum stat_item si)
>  {
>  #ifdef CONFIG_SLUB_STATS
> -	__this_cpu_inc(s->cpu_slab->stat[si]);
> +	raw_cpu_inc(s->cpu_slab->stat[si]);
>  #endif
>  }

Please always consider how the code will appear to a naive reader. 
That reader won't know why raw_ is being used here, so we should
provide an explanation.

--- a/mm/slub.c~slub-use-raw_cpu_inc-for-incrementing-statistics-fix
+++ a/mm/slub.c
@@ -224,6 +224,10 @@ static inline void memcg_propagate_slab_
 static inline void stat(const struct kmem_cache *s, enum stat_item si)
 {
 #ifdef CONFIG_SLUB_STATS
+	/*
+	 * The rmw is racy on a preemptible kernel but this is acceptable, so
+	 * avoid this_cpu_add()'s irq-disable overhead.
+	 */
 	raw_cpu_inc(s->cpu_slab->stat[si]);
 #endif
 }
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/