lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140321142429.GA25833@kroah.com>
Date:	Fri, 21 Mar 2014 07:24:29 -0700
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	Matt Sickler <Matt.Sickler@...tronics.com>
Cc:	"hjk@...sjkoch.de" <hjk@...sjkoch.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]: UIO read(2)/write(2) overrides

On Fri, Mar 21, 2014 at 02:20:11PM +0000, Matt Sickler wrote:
> Tiny patch to let uio-based drivers override the read(2), write(2), and poll(2) syscalls.
> The rationale is that some uio-based drivers might want the mmap(2) functionality
> of UIO, but have no need for the IRQ semantics of read(2) and write(2).

Can you submit a driver that uses these new interfaces as well?  I don't
want to add something that isn't used in the kernel.

> 
> Signed-Off-by: Matt Sickler <Matt.Sickler@...tronics.com>
> ---
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index a673e5b..da1bfc8 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -505,6 +505,9 @@ static unsigned int uio_poll(struct file *filep, poll_table *wait)
>     struct uio_listener *listener = filep->private_data;
>     struct uio_device *idev = listener->dev;
> 
> +   if (idev->info->poll)
> +       return idev->info->poll(filep, wait);
> +

Your email client ate all the tabs and created a patch that can't be
applied :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ