linux-kernel - Re: [PATCH] intel_pstate: Use del_timer_sync in intel_pstate_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Mar 2014 20:24:29 +0530
From:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
To:	dirk.brandewie@...il.com
CC:	linux-kernel@...r.kernel.org,
	Dirk Brandewie <dirk.j.brandewie@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	cpufreq <cpufreq@...r.kernel.org>
Subject: Re: [PATCH] intel_pstate:  Use del_timer_sync in intel_pstate_cpu_stop

On 03/24/2014 08:11 PM, dirk.brandewie@...il.com wrote:
> From: Dirk Brandewie <dirk.j.brandewie@...el.com>
> 
> Ensure that no timer callback is running since we are about to free
> the timer structure.  We cannot guarantee that the call back is called
> on the CPU where the timer is running.
> 
> Reported-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@...el.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: cpufreq <cpufreq@...r.kernel.org>

Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>

Regards,
Srivatsa S. Bhat

> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index e9092fd..a4a9ba5 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -780,7 +780,7 @@ static int intel_pstate_cpu_stop(struct cpufreq_policy *policy)
> 
>  	pr_info("intel_pstate CPU %d exiting\n", cpu_num);
> 
> -	del_timer(&all_cpu_data[cpu_num]->timer);
> +	del_timer_sync(&all_cpu_data[cpu_num]->timer);
>  	intel_pstate_set_pstate(cpu, cpu->pstate.min_pstate);
>  	kfree(all_cpu_data[cpu_num]);
>  	all_cpu_data[cpu_num] = NULL;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/