[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAOh2x=m9C77gYFbxQ1fn-ebQdL58OhY60rXq6WHyTR4Wau7_QA@mail.gmail.com>
Date: Tue, 25 Mar 2014 09:58:46 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Dirk Brandewie <dirk.brandewie@...il.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Dirk Brandewie <dirk.j.brandewie@...el.com>,
Thomas Gleixner <tglx@...utronix.de>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
cpufreq <cpufreq@...r.kernel.org>
Subject: Re: [PATCH] intel_pstate: Use del_timer_sync in intel_pstate_cpu_stop
On Mon, Mar 24, 2014 at 8:11 PM, <dirk.brandewie@...il.com> wrote:
> From: Dirk Brandewie <dirk.j.brandewie@...el.com>
>
> Ensure that no timer callback is running since we are about to free
> the timer structure. We cannot guarantee that the call back is called
> on the CPU where the timer is running.
>
> Reported-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@...el.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: cpufreq <cpufreq@...r.kernel.org>
> ---
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index e9092fd..a4a9ba5 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -780,7 +780,7 @@ static int intel_pstate_cpu_stop(struct cpufreq_policy *policy)
>
> pr_info("intel_pstate CPU %d exiting\n", cpu_num);
>
> - del_timer(&all_cpu_data[cpu_num]->timer);
> + del_timer_sync(&all_cpu_data[cpu_num]->timer);
> intel_pstate_set_pstate(cpu, cpu->pstate.min_pstate);
> kfree(all_cpu_data[cpu_num]);
> all_cpu_data[cpu_num] = NULL;
Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists