lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Mar 2014 11:43:48 -0400 From: Richard Guy Briggs <rgb@...hat.com> To: James Morris <jmorris@...ei.org> Cc: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>, peterz@...radead.org, paulmck@...ux.vnet.ibm.com, laijs@...fujitsu.com, akpm@...ux-foundation.org, joe@...ches.com, keescook@...omium.org, geert@...ux-m68k.org, jkosina@...e.cz, viro@...iv.linux.org.uk, davem@...emloft.net, linux-kernel@...r.kernel.org, mingo@...e.hu, rostedt@...dmis.org, tglx@...utronix.de, linux-security-module@...r.kernel.org Subject: Re: [PATCH] Change task_struct->comm to use RCU. On 14/03/12, James Morris wrote: > On Tue, 11 Mar 2014, Tetsuo Handa wrote: > > And the same phrase goes to James Morris... > > > > If you are sure that it is safe to use get_task_comm() from > > dump_common_audit_data() and you prefer locked version, please pick up below > > patch via your git tree. > > > > If you are unsure or prefer lockless version, I'll make a lockless version > > using do_get_task_comm() proposed in this thread. > > If you can't understand whether your patch is correct or not, don't ask me > to apply it to my tree. > > If you're unsure, get it reviewed first. I looked at the calling function tree back a number of steps and didn't see any other evidence of task locks held, so I'm comfortable with this patch and would prefer it to either memcpy() or do_get_task_comm(), but would still like to get an opinion from others. > - James - RGB -- Richard Guy Briggs <rbriggs@...hat.com> Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists