linux-kernel - Re: [PATCH] mtd: nand: fix mention to CONFIG_MTD_NAND_ECC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK4VdL33t-rbVGfj5xH3nVeGt5fjnZjvcNH+zZ=4Dibj7snsYg@mail.gmail.com>
Date:	Tue, 25 Mar 2014 19:28:30 -0300
From:	Erico Nunes <nunes.erico@...il.com>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Brian Norris <computersforpeace@...il.com>, b32955@...escale.com,
	artem.bityutskiy@...ux.intel.com,
	linux-mtd <linux-mtd@...ts.infradead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Erico Nunes <nunes.erico@...il.com>
Subject: Re: [PATCH] mtd: nand: fix mention to CONFIG_MTD_NAND_ECC_BCH

2014-03-11 1:31 GMT-03:00 Erico Nunes <nunes.erico@...il.com>:
> Mention to CONFIG_MTD_ECC_BCH in the warning message can be confusing as this
> doesn't match the exact name of the configuration option.
> This warning showed up once to me when I was starting to set up BCH. After
> checking my .config file, it took a moment before realizing it is
> CONFIG_MTD_NAND_ECC_BCH instead of CONFIG_MTD_ECC_BCH.
>
> Signed-off-by: Erico Nunes <nunes.erico@...il.com>
> ---
>  drivers/mtd/nand/nand_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 9715a7b..5a93787 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -3825,7 +3825,7 @@ int nand_scan_tail(struct mtd_info *mtd)
>
>         case NAND_ECC_SOFT_BCH:
>                 if (!mtd_nand_has_bch()) {
> -                       pr_warn("CONFIG_MTD_ECC_BCH not enabled\n");
> +                       pr_warn("CONFIG_MTD_NAND_ECC_BCH not enabled\n");
>                         BUG();
>                 }
>                 ecc->calculate = nand_bch_calculate_ecc;
> --
> 1.9.0
>

Ping.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/