linux-kernel - Re: [PATCH v3] clk: respect the clock dependencies in of_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGa+x85XLDZqCkz9R95d2Vj9eODx4q8W=9QhmMfivdPf2GdsaQ@mail.gmail.com>
Date:	Wed, 26 Mar 2014 08:19:39 -0700
From:	Kevin Hilman <khilman@...aro.org>
To:	Mike Turquette <mturquette@...aro.org>
Cc:	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Andrew Lunn <andrew@...n.ch>,
	Jason Cooper <jason@...edaemon.net>,
	Tomasz Figa <tomasz.figa@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
	Boris BREZILLON <b.brezillon@...rkiz.com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	Shawn Guo <shawn.guo@...aro.org>,
	Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v3] clk: respect the clock dependencies in of_clk_init

[+ imx6 maintainers ]

On Thu, Mar 20, 2014 at 8:52 PM, Mike Turquette <mturquette@...aro.org> wrote:
> Quoting Gregory CLEMENT (2014-02-28 02:46:12)
>> Hi Mike,
>>
>> On 24/02/2014 19:10, Gregory CLEMENT wrote:
>> > Until now the clock providers were initialized in the order found in
>> > the device tree. This led to have the dependencies between the clocks
>> > not respected: children clocks could be initialized before their
>> > parent clocks.
>> >
>> > Instead of forcing each platform to manage its own initialization order,
>> > this patch adds this work inside the framework itself.
>> >
>> > Using the data of the device tree the of_clk_init function now delayed
>> > the initialization of a clock provider if its parent provider was not
>> > ready yet.
>> >
>> > The strict dependency check (all parents of a given clk must be
>> > initialized) was added by Boris BREZILLON
>>
>> Are you ok with this version?
>> Will you take it for 3.15?
>> Or maybe you expected that it will be part of a pull request?
>>
>> However as it is modifying the core of the framework I thought that you
>> would take it and apply yourself.
>
> Hi Gregory,
>
> I have taken this into clk-next. If no regressions pop up over the next
> few days then it should go into 3.15.

$SUBJECT patch (as commit 1771b10d605) is in -next has been fingered
by bisection to be the reason behind boot failures[1] on imx6 wand
boards in the last several -next kernels.

Reverting the patch on top of next/master gets these boards booting again.

The boot failures result in no console output, so I haven't done any
further debugging.

Kevin

[1] http://lists.linaro.org/pipermail/kernel-build-reports/2014-March/002927.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/