linux-kernel - Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2014 21:09:02 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	"qiang.zhao@...escale.com" <qiang.zhao@...escale.com>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Scott Wood <scottwood@...escale.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"mugunthanvnm@...com" <mugunthanvnm@...com>,
	"zonque@...il.com" <zonque@...il.com>,
	"helmut.schaa@...glemail.com" <helmut.schaa@...glemail.com>,
	Xiaobo Xie <X.Xie@...escale.com>
Subject: Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode

Hello.

On 03/28/2014 10:36 AM, qiang.zhao@...escale.com wrote:

>>> The at8031 can work on polling mode and interrupt mode.
>>> Add ack_interrupt and config intr funcs to enable interrupt mode for
>>> it.

>>> Signed-off-by: Zhao Qiang <B45475@...escale.com>
>>> ---
>>>    drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++
>>>    1 file changed, 30 insertions(+)

>>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index
>>> bc71947..d034ef5 100644
>>> --- a/drivers/net/phy/at803x.c
>>> +++ b/drivers/net/phy/at803x.c
>> [...]
>>> @@ -191,6 +194,31 @@ static int at803x_config_init(struct phy_device
>> *phydev)
>>>    	return 0;
>>>    }
>>>
>>> +static int at803x_ack_interrupt(struct phy_device *phydev) {
>>> +	int err;
>>> +
>>> +	err = phy_read(phydev, AT803X_INSR);

>>      Could make this an initializer...

> Thank you very much. However I have no idea about "make this an initializer".

	int err = phy_read(phydev, AT803X_INSR);

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/