linux-kernel - Re: git pull -- [PATCH] aio: v2 ensure access to ctx->ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140328172229.GH29656@kvack.org>
Date:	Fri, 28 Mar 2014 13:22:29 -0400
From:	Benjamin LaHaise <bcrl@...ck.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	Tang Chen <tangchen@...fujitsu.com>,
	Gu Zheng <guz.fnst@...fujitsu.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>, linux-aio@...ck.org,
	linux-mm <linux-mm@...ck.org>
Subject: Re: git pull -- [PATCH] aio: v2 ensure access to ctx->ring_pages is correctly serialised

On Fri, Mar 28, 2014 at 10:08:47AM -0700, Linus Torvalds wrote:
> On Fri, Mar 28, 2014 at 7:58 AM, Benjamin LaHaise <bcrl@...ck.org> wrote:
> >
> > Here's a respin of that part.  I just moved the mutex initialization up so
> > that it's always valid in the err path.  I have also run this version of
> > the patch through xfstests and my migration test programs and it looks
> > okay.
> 
> Ok. I can't find any issues with this version. How critical is this?
> Should I take it now, or with more testing during the 3.15 merge
> window and then just have it picked up from stable? Do people actually
> trigger the bug in real life, or has this been more of a
> trinity/source code analysis thing?

I believe it was found by analysis.  I'd be okay with it baking for another 
week or two before pushing it to stable, as that gives the folks running 
various regression tests some more time to chime in.  Better to get it 
right than to have to push another fix.

		-ben
-- 
"Thought is the essence of where you are now."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/