linux-kernel - Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140328075942.GD17779@lee--X1>
Date:	Fri, 28 Mar 2014 07:59:42 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Roger <rogerable@...ltek.com>
Cc:	Oliver Neukum <oneukum@...e.de>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Chris Ball <chris@...ntf.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Maxim Levitsky <maximlevitsky@...il.com>,
	Alex Dubov <oakad@...oo.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org, wei_wang@...lsil.com.cn,
	micky_ching@...lsil.com.cn
Subject: Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

[...]

> >>+static int rtsx_usb_suspend(struct usb_interface *intf, pm_message_t message)
> >>+{
> >>+	struct rtsx_ucr *ucr =
> >>+		(struct rtsx_ucr *)usb_get_intfdata(intf);
> >>+
> >>+	dev_dbg(&intf->dev, "%s called with pm message 0x%04u\n",
> >>+			__func__, message.event);
> >>+
> >>+	mutex_lock(&ucr->dev_mutex);
> >>+	rtsx_usb_turn_off_led(ucr);
> >
> >When is this turned on again?
> >
> 
> The LED is not in a permanent cut-off state after here. It is called
> to guarantee the LED is off during suspend to save more power. It
> could be lit up in the card host drivers(e.g. rtsx_usb_sdmmc.c)
> anytime whenever necessary.
> 
> This has been asked may times. I'm considering putting some comment
> in next revision.

Yes, please do.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/