lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Mar 2014 18:11:04 +0100 From: Jiri Olsa <jolsa@...hat.com> To: Don Zickus <dzickus@...hat.com> Cc: acme@...stprotocols.net, LKML <linux-kernel@...r.kernel.org>, jmario@...hat.com, fowles@...each.com Subject: Re: [PATCH 3/4] perf, callchain: Add generic report parse callchain callback function On Mon, Mar 24, 2014 at 03:32:56PM -0400, Don Zickus wrote: > This takes the parse_callchain_opt function and copies it into the > callchain.c file. Now the c2c tool can use it too without duplicating. > > Signed-off-by: Don Zickus <dzickus@...hat.com> > --- > tools/perf/util/callchain.c | 83 +++++++++++++++++++++++++++++++++++++++++++++ > tools/perf/util/callchain.h | 1 + > 2 files changed, 84 insertions(+) > > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c > index 8d9db45..2320678 100644 > --- a/tools/perf/util/callchain.c > +++ b/tools/perf/util/callchain.c > @@ -25,6 +25,89 @@ > > __thread struct callchain_cursor callchain_cursor; > > +int > +report_parse_callchain_opt(const char *arg) > +{ > + //struct report *rep = (struct report *)opt->value; please erase ^^^ and I think it's better to merge this with the actual removal in following patch: perf, report: Use new generic report parse callchain callback jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists