linux-kernel - [RFC] quiet checkpatch style recommendation about no spaces around bitfield :

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396279898.21529.39.camel@joe-AO722>
Date:	Mon, 31 Mar 2014 08:31:38 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Rocco Folino <lordzen87@...il.com>, aaro.koskinen@....fi,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...onical.com>
Subject: [RFC] quiet checkpatch style recommendation about no spaces around
 bitfield :

On Mon, 2014-03-31 at 18:06 +0300, Dan Carpenter wrote:
> On Mon, Mar 31, 2014 at 02:34:40PM +0200, Rocco Folino wrote:
> > Fixed bit fields code style issues
[]
> > diff --git a/drivers/staging/octeon-usb/octeon-hcd.h b/drivers/staging/octeon-usb/octeon-hcd.h
[]
> > @@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg {
> >  	 *	* 1'b1: Unmask the interrupt assertion to the application.
> >  	 */
> >  	struct cvmx_usbcx_gahbcfg_s {
> > -		uint32_t reserved_9_31	: 23;
> > -		uint32_t ptxfemplvl	: 1;
> > -		uint32_t nptxfemplvl	: 1;
> > -		uint32_t reserved_6_6	: 1;
> > -		uint32_t dmaen		: 1;
> > -		uint32_t hbstlen	: 4;
> > -		uint32_t glblintrmsk	: 1;
> > +		uint32_t reserved_9_31:23;
> > +		uint32_t ptxfemplvl:1;
> > +		uint32_t nptxfemplvl:1;
> > +		uint32_t reserved_6_6:1;
> > +		uint32_t dmaen:1;
> > +		uint32_t hbstlen:4;
> > +		uint32_t glblintrmsk:1;
> >  	} s;
> The warning here is:
> ERROR: spaces prohibited around that ':' (ctx:WxW)
> I have done a kernel wide search for these warnings

Really?  How?

>  and I think we
> should disable this warning.  It has too many false positives like this.

It does seem a bit noisy to me too.

Andy?  Andrew?

>From a treewide checkpatch scan next-20140307:

$ grep "spaces prohibited around that ':' (ctx:WxW)" checkpatch.all | wc -l
11194

I don't see any other uses of that message for
anything other than bitfields.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/