linux-kernel - Re: [RFC] quiet checkpatch style recommendation about no spaces around bitfield :

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140331194416.GR6991@mwanda>
Date:	Mon, 31 Mar 2014 22:44:16 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	devel@...verdev.osuosl.org, Rocco Folino <lordzen87@...il.com>,
	aaro.koskinen@....fi, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC] quiet checkpatch style recommendation about no spaces
 around bitfield :

On Mon, Mar 31, 2014 at 08:31:38AM -0700, Joe Perches wrote:
> On Mon, 2014-03-31 at 18:06 +0300, Dan Carpenter wrote:
> > On Mon, Mar 31, 2014 at 02:34:40PM +0200, Rocco Folino wrote:
> > > Fixed bit fields code style issues
> []
> > > diff --git a/drivers/staging/octeon-usb/octeon-hcd.h b/drivers/staging/octeon-usb/octeon-hcd.h
> []
> > > @@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg {
> > >  	 *	* 1'b1: Unmask the interrupt assertion to the application.
> > >  	 */
> > >  	struct cvmx_usbcx_gahbcfg_s {
> > > -		uint32_t reserved_9_31	: 23;
> > > -		uint32_t ptxfemplvl	: 1;
> > > -		uint32_t nptxfemplvl	: 1;
> > > -		uint32_t reserved_6_6	: 1;
> > > -		uint32_t dmaen		: 1;
> > > -		uint32_t hbstlen	: 4;
> > > -		uint32_t glblintrmsk	: 1;
> > > +		uint32_t reserved_9_31:23;
> > > +		uint32_t ptxfemplvl:1;
> > > +		uint32_t nptxfemplvl:1;
> > > +		uint32_t reserved_6_6:1;
> > > +		uint32_t dmaen:1;
> > > +		uint32_t hbstlen:4;
> > > +		uint32_t glblintrmsk:1;
> > >  	} s;
> > The warning here is:
> > ERROR: spaces prohibited around that ':' (ctx:WxW)
> > I have done a kernel wide search for these warnings
> 
> Really?  How?

Just a:

find -name \*.[ch] -exec ./scripts/checkpatch.pl -f \{\} \;

Or whatever...  It takes 2 1/2 hours.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/