linux-kernel - Re: [GIT PULL] x86/iommu change for v3.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyAi0Vh6L5C8G6Jm3-FP81TNZekM_MiN-0wA3vvg3tSCQ@mail.gmail.com>
Date:	Mon, 31 Mar 2014 12:34:28 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ingo Molnar <mingo@...nel.org>, Neil Horman <nhorman@...driver.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] x86/iommu change for v3.15

On Mon, Mar 31, 2014 at 7:49 AM, Ingo Molnar <mingo@...nel.org> wrote:
> Neil Horman (1):
>       x86: Adjust irq remapping quirk for older revisions of 5500/5520 chipsets

Before I pull this, I want somebody to double-check it:

> -       if (revision == 0x13)
> +       if (revision < 0x13)
>                 set_irq_remapping_broken();

This change does *not* match the comment just above it. The comment
talks very much about revision 13.

So the comment should be fixed, and/or that "< 0x13" should perhaps be
"<= 0x13".

Because making it "less than" simply makes no sense in light of the
comment. Does revision 13 suddenly work? Was that where it was fixed?
If so, please fix the comment.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/