linux-kernel - Re: [GIT PULL] x86/iommu change for v3.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1403312144280.14882@ionos.tec.linutronix.de>
Date:	Mon, 31 Mar 2014 21:45:43 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Ingo Molnar <mingo@...nel.org>,
	Neil Horman <nhorman@...driver.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] x86/iommu change for v3.15

On Mon, 31 Mar 2014, Linus Torvalds wrote:

> On Mon, Mar 31, 2014 at 7:49 AM, Ingo Molnar <mingo@...nel.org> wrote:
> > Neil Horman (1):
> >       x86: Adjust irq remapping quirk for older revisions of 5500/5520 chipsets
> 
> Before I pull this, I want somebody to double-check it:
> 
> > -       if (revision == 0x13)
> > +       if (revision < 0x13)
> >                 set_irq_remapping_broken();
> 
> This change does *not* match the comment just above it. The comment
> talks very much about revision 13.
> 
> So the comment should be fixed, and/or that "< 0x13" should perhaps be
> "<= 0x13".
> 
> Because making it "less than" simply makes no sense in light of the
> comment. Does revision 13 suddenly work? Was that where it was fixed?
> If so, please fix the comment.

That is my bad. I applied V1 of the patch instead of V2 which had the
<= 0x13 instead of < 0x13.

Please drop the pull request for now. I'll fix it up and we resubmit.

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/