[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140401140254.GS6991@mwanda>
Date: Tue, 1 Apr 2014 17:02:54 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Guido Martínez <guido@...guardiasur.com.ar>
Cc: linux-kernel@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
driverdev-devel@...uxdriverproject.org,
Ezequiel García
<ezequiel@...guardiasur.com.ar>,
Walter Lozano <walter@...guardiasur.com.ar>,
Forest Bond <forest@...ttletooquiet.net>
Subject: Re: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros
On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote:
> Parenthesize both macros so they will not break program logic if used
> within another 'if'. Also fix a usage of DBG_PRT with a missing
> semicolon.
>
> Signed-off-by: Guido Martínez <guido@...guardiasur.com.ar>
> ---
> drivers/staging/vt6655/device.h | 4 ++--
> drivers/staging/vt6655/wpactl.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index 062c3a3..483b017 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -148,8 +148,8 @@
>
> /*--------------------- Export Types ------------------------------*/
>
> -#define DBG_PRT(l, p, args...) { if (l <= msglevel) printk(p, ##args); }
> -#define PRINT_K(p, args...) { if (PRIVATE_Message) printk(p, ##args); }
> +#define DBG_PRT(l, p, args...) ({ if (l <= msglevel) printk(p, ##args); })
> +#define PRINT_K(p, args...) ({ if (PRIVATE_Message) printk(p, ##args); })
Use a do { } while(0) for this.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists