linux-kernel - Re: [PATCH 3/3] staging: vt6655: fix checkpatch bracing issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140401141302.GT6991@mwanda>
Date:	Tue, 1 Apr 2014 17:13:02 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Guido Martínez <guido@...guardiasur.com.ar>
Cc:	linux-kernel@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
	driverdev-devel@...uxdriverproject.org,
	Ezequiel García 
	<ezequiel@...guardiasur.com.ar>,
	Walter Lozano <walter@...guardiasur.com.ar>,
	Forest Bond <forest@...ttletooquiet.net>
Subject: Re: [PATCH 3/3] staging: vt6655: fix checkpatch bracing issues

On Tue, Apr 01, 2014 at 09:52:13AM -0300, Guido Martínez wrote:
> @@ -624,13 +622,10 @@ device_receive_frame(
>  
>  // Data frame Handle
>  
> -	if (pDevice->bEnablePSMode) {
> -		if (!IS_FC_MOREDATA((skb->data+4))) {
> +	if (pDevice->bEnablePSMode)
> +		if (!IS_FC_MOREDATA((skb->data+4)))
>  			if (pDevice->pMgmt->bInTIMWake == true)
>  				pDevice->pMgmt->bInTIMWake = false;
> -			}
> -		}
> -	}

Use braces for multi-line indents for readability.

> @@ -1502,26 +1501,26 @@ int iwctl_siwauth(struct net_device *dev,
>  		break;
>  	case IW_AUTH_CIPHER_PAIRWISE:
>  		pairwise = wrq->value;
> -		if (pairwise == IW_AUTH_CIPHER_CCMP) {
> +		if (pairwise == IW_AUTH_CIPHER_CCMP)
>  			pDevice->eEncryptionStatus = Ndis802_11Encryption3Enabled;
> -		} else if (pairwise == IW_AUTH_CIPHER_TKIP) {
> +		else if (pairwise == IW_AUTH_CIPHER_TKIP)
>  			pDevice->eEncryptionStatus = Ndis802_11Encryption2Enabled;
> -		} else if (pairwise == IW_AUTH_CIPHER_WEP40 || pairwise == IW_AUTH_CIPHER_WEP104) {
> +		else if (pairwise == IW_AUTH_CIPHER_WEP40 || pairwise == IW_AUTH_CIPHER_WEP104)
>  			pDevice->eEncryptionStatus = Ndis802_11Encryption1Enabled;
> -		} else if (pairwise == IW_AUTH_CIPHER_NONE) {
> -			//do nothing,einsn liu
> -		} else pDevice->eEncryptionStatus = Ndis802_11EncryptionDisabled;
> +		else if (pairwise == IW_AUTH_CIPHER_NONE)
> +			; //do nothing,einsn liu
> +		else
> +		pDevice->eEncryptionStatus = Ndis802_11EncryptionDisabled;
>  

The indenting is messed up on the last else statement.

> @@ -276,24 +276,20 @@ PSbSendNullPacket(
>  	PSMgmtObject        pMgmt = pDevice->pMgmt;
>  	unsigned int uIdx;
>  
> -	if (!pDevice->bLinkPass) {
> +	if (!pDevice->bLinkPass)
>  		return false;
> -	}
> +
>  #ifdef TxInSleep
> -	if (!pDevice->bEnablePSMode && !pDevice->fTxDataInSleep) {
> +	if (!pDevice->bEnablePSMode && !pDevice->fTxDataInSleep)
>  		return false;
> -	}
>  #else
> -	if (!pDevice->bEnablePSMode) {
> +	if (!pDevice->bEnablePSMode)
>  		return false;
> -	}
>  #endif
> -	if (pDevice->bEnablePSMode) {
> -		for (uIdx = 0; uIdx < TYPE_MAXTD; uIdx++) {
> +	if (pDevice->bEnablePSMode)
> +		for (uIdx = 0; uIdx < TYPE_MAXTD; uIdx++)
>  			if (pDevice->iTDUsed[uIdx] != 0)
>  				return false;
> -		}
> -	}


Multi-line indent.


> @@ -4285,14 +4252,9 @@ vMgrRxManagePacket(
>  
>  	case WLAN_FSTYPE_BEACON:
>  		// Frame Clase = 0
> -<<<<<<< HEAD
> -		//DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "rx beacon\n");
> -		if (pMgmt->eScanState != WMAC_NO_SCANNING) {
> -=======
>  		if (pMgmt->eScanState != WMAC_NO_SCANNING)
> ->>>>>>> f3c59ed... staging: vt6655: remove dead code
>  			bInScan = true;
> -		}
> +
>  		s_vMgrRxBeacon(pDevice, pMgmt, pRxPacket, bInScan);
>  		break;
>  
> @@ -4357,16 +4319,11 @@ bMgrPrepareBeaconToSend(
>  	PSDevice            pDevice = (PSDevice)hDeviceContext;
>  	PSTxMgmtPacket      pTxPacket;
>  
> -<<<<<<< HEAD
> -//    pDevice->bBeaconBufReady = false;
> -	if (pDevice->bEncryptionEnable || pDevice->bEnable8021x) {
> -=======
>  	if (pDevice->bEncryptionEnable || pDevice->bEnable8021x)
> ->>>>>>> f3c59ed... staging: vt6655: remove dead code
>  		pMgmt->wCurrCapInfo |= WLAN_SET_CAP_INFO_PRIVACY(1);
> -	} else {
> +	else
>  		pMgmt->wCurrCapInfo &= ~WLAN_SET_CAP_INFO_PRIVACY(1);
> -	}
> +

Wat?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/