lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140401141951.GU6991@mwanda>
Date:	Tue, 1 Apr 2014 17:19:51 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Guido Martínez <guido@...guardiasur.com.ar>
Cc:	linux-kernel@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
	driverdev-devel@...uxdriverproject.org,
	Ezequiel García 
	<ezequiel@...guardiasur.com.ar>,
	Walter Lozano <walter@...guardiasur.com.ar>,
	Forest Bond <forest@...ttletooquiet.net>
Subject: Re: [PATCH 2/3] staging: vt6655: remove dead code

On Tue, Apr 01, 2014 at 09:52:12AM -0300, Guido Martínez wrote:
> @@ -2205,11 +2203,8 @@ bool BBbVT3253Init(PSDevice pDevice)
>  		//}}
>  		bResult &= BBbWriteEmbedded(dwIoBase, 0xb0, 0x58);
>  
> -		for (ii = 0; ii < CB_VT3253B0_AGC; ii++) {
> +		for (ii = 0; ii < CB_VT3253B0_AGC; ii++)
>  			bResult &= BBbWriteEmbedded(dwIoBase, byVT3253B0_AGC[ii][0], byVT3253B0_AGC[ii][1]);
> -		}

This isn't "deleting dead code".  Do it in a separate patch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ