linux-kernel - Re: [v2 PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of WB_SYNC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140401135023.9ca9e1e4d15bb54981443346@linux-foundation.org>
Date:	Tue, 1 Apr 2014 13:50:23 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Roman Pen <r.peniaev@...il.com>
Cc:	Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v2 PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of
 WB_SYNC_ALL

On Sat, 15 Mar 2014 00:34:28 +0900 Roman Pen <r.peniaev@...il.com> wrote:

> When data integrity operation happens (sync, fsync, fdatasync calls)
> writeback control is set to WB_SYNC_ALL. In that case all write
> requests are marked with WRITE_SYNC (WRITE | REQ_SYNC | REQ_NOIDLE)
> indicating that caller is waiting for completion and block layer or
> block device should prioritize the IO avoiding any possible delays.
> 
> But mpage writeback path ignores marking requests as WRITE_SYNC.
> 
> This patch fixes this.

Sorry, but it would be unwise to merge this without a good
understanding of its runtime effects.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/