linux-kernel - Re: [GIT PULL] x86 LTO changes for v3.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140402083325.2b6e5d8b@gandalf.local.home>
Date:	Wed, 2 Apr 2014 08:33:25 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Gleb Natapov <gleb@...hat.com>, Peter Anvin <hpa@...or.com>,
	Jan Hubicka <hubicka@....cz>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Paolo Bonzini <pbonzini@...hat.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Peter Zijlstra <peterz@...radead.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [GIT PULL] x86 LTO changes for v3.15

On Tue, 1 Apr 2014 17:35:05 -0700
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Tue, Apr 1, 2014 at 5:01 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > Why would they break tracing? I remember there was a issue with compat
> > calls, are these related to that?
> 
> They "break" tracing by being invisible to syscall tracing. As you
> really should know ;)
> 
> The syscall tracing feature depends on the wrappers that
> SYSCALL_DEFINEx() creates. See the SYSCALL_TRACE_ENTER_EVENT() etc
> crud in <linux/syscalls.h>
> 
> So there's no SYSCALL_METADATA for those system calls that weren't
> created with the proper SYSCALL_DEFINE() wrappers.
> 

Heh, I know that not having the SYSCALL_DEFINEx() wrappers means that
they wont be traced. I must have misunderstood Peter, as I thought he
meant if we added SYSCALL_DEFINEx(), that they would break tracing.

IIRC, the compat calls had some issues with the SYSCALL_DEFINE()
macros, and I was thinking theses functions would have some off the
wall issue as well.

Yeah, adding the SYSCALL_DEFINEx() macros around those functions would
be good for tracing as well.

Glad I understand you two now ;-)

I would have thought my jet lag would be over by now.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/