linux-kernel - Re: [GIT PULL] USB patches for 3.15-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <533C0B45.4050909@ti.com>
Date:	Wed, 2 Apr 2014 18:36:13 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Loc Ho <lho@....com>, Greg KH <gregkh@...uxfoundation.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [GIT PULL] USB patches for 3.15-rc1

Hi,

On Wednesday 02 April 2014 11:12 AM, Loc Ho wrote:
> Hi,
> 
>>>> USB patches for 3.15-rc1
>>>>
>>>> Here's the big USB pull request for 3.15-rc1.
>>>
>>> Hmm. I'm getting this when testing:
>>>
>>>   warning: (AHCI_XGENE) selects PHY_XGENE which has unmet direct
>>> dependencies (HAS_IOMEM && OF && (ARM64 || COMPILE_TEST))
>>>
>>> which looks like AHCI_XGENE doesn't have the proper dependency on OF
>>> (or alternatively PHY_XGENE has an incorrect dependemcy on OF).
>>>
>>> According to google it looks like Fengguang reported this on
>>> kbuild-all, but nowhere else.
>>>
>>> The actual build then succeeds. But the Kconfig warning is real and
>>> implies that something is seriously wrong wrt the dependencies for
>>> this thing.
>>>
>>> It looks like the "select PHY_XGENE" came in through the libata
>>> update, but this USB update actually brought in the "config PHY_XGENE"
>>> and thus this error. Which makes me wonder how this all worked. Why
>>> does that "select PHY_XGENE" exist when apparently it's not needed?
>>>
>>> Regardless, there's something broken somewhere.
>>
>> Odd, I don't know what to do to fix this up "properly".
>>
>> Loc Ho, this came in from your patch, any ideas?

Shouldn't we let the users to enable PHY_XGENE (maybe add in the platform
defconfig)?

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/