linux-kernel - Re: [PATCH] phy: don't return error from the stubs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140402141506.GB8504@saruman.home>
Date:	Wed, 2 Apr 2014 09:15:06 -0500
From:	Felipe Balbi <balbi@...com>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
CC:	Kishon Vijay Abraham I <kishon@...com>,
	Felipe Balbi <balbi@...com>, <chiau.ee.chew@...el.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: don't return error from the stubs

On Wed, Apr 02, 2014 at 03:25:43PM +0300, Heikki Krogerus wrote:
> Returning 0 from the stubs for the functions that are used
> for PHY controlling. The interface should not appear to be
> failing with every operation when the framework is not
> enabled.
> 
> This fixes an issue in dwc3 driver, where the driver fails
> the moment first phy_*() call is made when the framework is
> not enabled.
> 
> Reported-by: Chew, Chiau Ee <chiau.ee.chew@...el.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

Yeah, I'll ack this one because for platforms who really don't need to
SW control a PHY, we need at least *one* way of not depending on it.

Acked-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)