linux-kernel - Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Apr 2014 20:14:24 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Alexandre Oliva <oliva@....org>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable
 as static

On 3 April 2014 18:10, Alexandre Oliva <oliva@....org> wrote:
> FWIW, the same mistake is present in at32.

I will check others as well now :)

> I've just finished bisecting the cpufreq regression on loongson2.
> Indeed, this s/static// patch does not fix it, but it was 652ed95d5fa,
> the patch that moved cpuclk into loongson2_cpufreq_cpu_init, that caused
> the regression.
>
> Reverting all the changes to loongson2_cpufreq.c in 652ed95d5fa makes
> cpufreq work again, as opposed to printing nan% in all cpufreq stats in
> cpufreq-info's output, and freezing shortly thereafter.

You must have a look at this:

https://lkml.org/lkml/2014/4/2/426 : [PATCH] MIPS/loongson2_cpufreq:
fix CPU clock rate setting
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/