| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 03 Apr 2014 09:40:57 -0300 From: Alexandre Oliva <oliva@....org> To: Viresh Kumar <viresh.kumar@...aro.org> Cc: rjw@...ysocki.net, linaro-kernel@...ts.linaro.org, cpufreq@...r.kernel.org, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static On Apr 2, 2014, Viresh Kumar <viresh.kumar@...aro.org> wrote: > did some changes to driver and by mistake made cpuclk as a 'static' local > variable, which wasn't actually required. Fix it. FWIW, the same mistake is present in at32. I've just finished bisecting the cpufreq regression on loongson2. Indeed, this s/static// patch does not fix it, but it was 652ed95d5fa, the patch that moved cpuclk into loongson2_cpufreq_cpu_init, that caused the regression. Reverting all the changes to loongson2_cpufreq.c in 652ed95d5fa makes cpufreq work again, as opposed to printing nan% in all cpufreq stats in cpufreq-info's output, and freezing shortly thereafter. > - static struct clk *cpuclk; > + struct clk *cpuclk; -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists