linux-kernel - Re: [PATCH 1/2] fixup: "powerpc/perf: Add support for the hv 24x7 interface"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Apr 2014 09:48:30 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Cody P Schafer <cody@...ux.vnet.ibm.com>
Cc:	Michael Ellerman <michael@...erman.id.au>,
	Linux PPC <linuxppc-dev@...ts.ozlabs.org>,
	cody+local@...ux.vnet.ibm.com, LKML <linux-kernel@...r.kernel.org>,
	David.Laight@...lab.com, Anton Blanchard <anton@...ba.org>
Subject: Re: [PATCH 1/2] fixup: "powerpc/perf: Add support for the hv 24x7
 interface"

On Wed, 2014-04-02 at 15:10 -0700, Cody P Schafer wrote:
> Make the "not enabled" message less awful.
> 
> Signed-off-by: Cody P Schafer <cody@...ux.vnet.ibm.com>
> ---
>  arch/powerpc/perf/hv-24x7.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
> index 297c9105..3246ea2 100644
> --- a/arch/powerpc/perf/hv-24x7.c
> +++ b/arch/powerpc/perf/hv-24x7.c
> @@ -491,7 +491,7 @@ static int hv_24x7_init(void)
>  
>  	hret = hv_perf_caps_get(&caps);
>  	if (hret) {
> -		pr_info("could not obtain capabilities, error 0x%80lx, not enabling\n",
> +		pr_info("could not obtain capabilities, not enabling (%ld)\n",
>  				hret);

That's not much less awful... The message gives 0 informations about
where it comes from .. what is it that couldn't obtain capabilities ?

Also, sentences start with a Capital.

Cheers,
Ben.
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/